Closed
Opened by Urban Wallasch @Irrwahn

Warnings compiling backend

During backend compilation the compiler issues the following three warnings: 

src/core_functions.c: In function \xe2\x80\x98disconnectActiveConnection':
src/core_functions.c:471:2: warning: \xe2\x80\x98net_interface' may be used uninitialized in this function [-Wmaybe-uninitialized]

src/file_functions.c: In function \xe2\x80\x98moveEditEssidFile':
src/file_functions.c:68:29: warning: unused parameter \xe2\x80\x98wlan' [-Wunused-parameter]

src/automated_scanner.c: In function \xe2\x80\x98getRadiatingWifiList':
src/automated_scanner.c:299:13: warning: \xe2\x80\x98tmp_wifi_quality' may be used uninitialized in this function [-Wmaybe-uninitialized]

While the second one is harmless, it is not immediately obvious, if the first and last might indicate more serious problems. In case it can be shown they are just noise better silence them off by properly initializing the respective referenced variables.

  • Edward Bartolo
    Edward Bartolo @edbarx ·

    gcc warning: "src/core_functions.c:471:2: warning: \xe2\x80\x98net_interface' may be used uninitialized in this function [-Wmaybe-uninitialized" This is a false warning. At line 471 net_interface must be initialised as either wired or wireless must be equal to 1.

    src/file_functions.c:68:29: warning: unused parameter \xe2\x80\x98wlan' [-Wunused-parameter] The parameter is unused, but it doesn't affect functionality, as inside the function a reference to wlanx, a global variable, is used instead. Nevertheless, I will review the code to correct it.

    src/automated_scanner.c: In function \xe2\x80\x98getRadiatingWifiList': src/automated_scanner.c:299:13: warning: \xe2\x80\x98tmp_wifi_quality' may be used uninitialized in this function [-Wmaybe-uninitialized] At the mentioned point in code tmp_wifi_quality is being initialised with values. The code works by using modulo division by two looking at the remainder which can only be {0, 1}.

  • Edward Bartolo @edbarx closed ·

    closed