• James Nylen
  • devuan-www
  • Issues
  • #1

Closed
Open
Opened 2019-08-23T01:41Z by golinux @golinux

Changes to Devuan website

Changes should be made to beta.devuan.org before going to master so those patches will not be merged as submitted. And please open an issue or come to irc to discuss before committing so that language and presentation are consistent. Thanks.

edit - 1. Your suggestion to add "migration from Debian" (with slightly different formatting) to the getdevuan page is a nice clarification. It has been added first to beta.devuan.org and then to the live site.

The reminder to "apt-get update" is helpful.

But regarding the expansion of information about removing libsystemd0 . . . I think it might be preferable to remove any mention of it at all rather than make a bigger deal about it. Why? The problem of its presence is mental not technical. Please see: https://dev1galaxy.org/viewtopic.php?id=1925 Also with the introduction of elogind0 in Beowulf, libsystemd0 is no longer present. I will discuss this with the team before making changes on the site.

I am not quite sure what to do with your commits so I leave that to you.

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Edited 2019-08-23T06:06Z by golinux
  • golinux @golinux changed the description 2 times within 3 minutes · 2019-08-23T06:06Z

    changed the description 2 times within 3 minutes

  • Andy Alt
    Andy Alt @andy5995 · 2019-08-26T22:32Z

    @golinux looks like some of this message is for @nylen but you didn't ping him. ;)

    I know on Github, when you @ping someone in an issue, they get notified by email by default.

  • Andy Alt
    Andy Alt @andy5995 · 2019-08-26T22:33Z

    or maybe @nylen did get notified.. I see now @golinux opened this on the @nylen fork, not the main repo...

  • golinux
    golinux @golinux · 2019-08-26T23:50Z

    @andy5995 Exactly. :) He was just a bit slow in responding. I will repeat here that it's a good idea and will reduce confusion to discuss changes in a git issue or #devuan-www or pm etc. before making commits.

  • James Nylen
    James Nylen @nylen · 2019-08-27T03:53Z

    Thanks for the follow-up. The email notifications for this issue got sent to my spam box, it looks like you may need to configure DKIM or other related arcana.

    In the future I will open an issue first. However I am fine with using a merge request as a way to explore a change, knowing that it may need revision or it may not be exactly what you want. To me this is a more definitive contribution than opening an issue and it is easier for me than setting up an IRC client. Once a merge request is already open it should also be easier for you to use the GitLab review tools to suggest any needed changes.

    Let's move the discussion over to https://git.devuan.org/devuan-editors/devuan-www/merge_requests/101 which is still open, and I will make another commit there to address the changes suggested here.

  • James Nylen @nylen closed · 2019-08-27T03:55Z

    closed

  • James Nylen
    James Nylen @nylen · 2019-08-27T04:24Z

    The email notifications for this issue got sent to my spam box

    I just looked again and confirmed there was no notification sent when this issue was created, only when Andy pinged me directly.

  • golinux
    golinux @golinux · 2019-08-27T04:39Z

    I assumed it would be since you are the main participant here. Have no idea why that didn't happen. I have been receiving all notifications.

    Edited by golinux 2019-08-27T04:39Z
  • Andy Alt
    Andy Alt @andy5995 · 2019-08-27T05:55Z

    I assumed it would be since you are the main participant here. Have no idea why that didn't happen. I have been receiving all notifications.

    I think, @golinux it's because you opened the issue on his fork, instead of commenting directly on his merge request. (Though really if someone opens an issue on someone's fork, the fork owner should get notified. Maybe a Gitlab bug...)

    I will repeat here that it's a good idea and will reduce confusion to discuss changes in a git issue or #devuan-www or pm etc. before making commits

    Ok, if that's what you wish. But should I assume when you say "commits" that you mean "merge requests"? Because only admins can actually make commits.

    I think it can sometimes be more convenient for potential contributors to make merge requests before discussion happens, because otherwise to open the discussion, someone has to mention a page and then quote some block of text. Whereas otherwise if someone submits a merge request, the affected changes can be seen and discussion can take place on the merge request itself, and it becomes easier to reference a particular line. Or if the change isn't wanted at all, the reviewer (admin) can simply close the merge request without committing it to the repo.

    Some projects choose to point out something in contributor docs something like

    "If you thing something should be changed, open an issue or discuss it first. If you submit a merge request, you may find that it's not wanted and it will be closed"

    Which basically just gives the contributor fair warning their merge request may get closed without merging.

    It's more for the case when a contributor sees something very obvious that should be changed and is confident that their merge request will not be closed without discussion.

  • golinux
    golinux @golinux · 2019-08-27T06:25Z

    In the 4+ years I've been maintaining the website, I have never seen a discussion on a merge request so it never occurred to me to do so. Content/changes were discussed refined elsewhere and then I put them on the site. So this is a new workflow for me and it's going to take some time for me to adapt. I am easily overwhelmed and it's been a little stressful dealing with new contributors who are used to doing things differently . . .

    Edited by golinux 2019-08-27T06:27Z
  • Andy Alt
    Andy Alt @andy5995 · 2019-08-27T19:11Z

    I can relate to getting overwhelmed and stressed.. ;) I've joined the www chat room and I'll use that, or open a git issue, if I notice anything. If there's anything I can do to help things be smooth and non-overwhelming, let me know. :)

  • golinux
    golinux @golinux · 2019-08-27T20:23Z

    Yes. That's much better than all those emails coming in all the time. Thanks. You'll understand better when you get to 77. :)

    Edited by golinux 2019-08-27T20:23Z
  • Andy Alt
    Andy Alt @andy5995 · 2019-08-27T20:50Z

    @nylen You might like https://www.irccloud.com/ if you don't want to bother with IRC clients.